-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude socket metrics #9770
Exclude socket metrics #9770
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @domcyrus! |
Hi @domcyrus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
Looks good to me, could you please add an e2e test case for this?
/ok-to-test
@tao12345666333 I've added an e2e test case for metrics. |
/assign I have added this to my list, I will finish review ASAP |
@tao12345666333 just a friendly ping if you already had the time to look into this or if I could somehow help on it in some way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
Hi @tao12345666333, just a friendly reminder I hope you don't mind. Is there anything else I can help with this PR or anything I can do to help it being merged? |
Don't worry, I have too many things to do. Feel free to ping me if I haven't dealt with it. I have added this to my list and will finish it tomorrow. |
Hi @tao12345666333, just another friendly reminder. I hope this message doesn't annoy you but I'm still interested in figuring out whether I can help you in some way with this PR or if there is something else I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: domcyrus, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Feature to remove potentially expensive prometheus socket metrics for example histograms like connect_duration_seconds.
Types of changes
Which issue/s this PR fixes
fixes #9738
How Has This Been Tested?
Added unit tests.
Checklist:
Does my pull request need a release note?